Warning in theme settings

Home Forums Bug reports Warning in theme settings

This topic contains 5 replies, has 2 voices, and was last updated by  Andy 3 years, 10 months ago.

Viewing 6 posts - 1 through 6 (of 6 total)
  • Author
    Posts
  • #282

    Zenger
    Member

    Hi, I’d like to report a bug.
    I’ve generated a child theme right after the activation, the LiftOff theme.
    When visiting LiftOff’s settings there is a warning ( see screenshot here http://i.imgur.com/WY9C99C.png).
    I’ve made a change to the radio-buttons-image.php file to fix this issue.
    Here is the changed http://paste.kde.org/p90a17c9d/ file and the diff file http://paste.kde.org/p208291a1/.
    Also could you please keep this framework at github? It would be easier to fork it and submit patches as well as use github’s issues.
    Another question: What is the license for the framework?
    Can I use it in my commercial projects? Thank you.

    • This topic was modified 4 years ago by  Zenger.
    #284

    Zenger
    Member

    I’d like to point another possible issue. I’ve noticed that the framework tries to pickup any file in the “data-types” folder even non php files. Try adding any file at all. It tires to include it and use a class that the file might not have. This is really bad, imagine if the framework would include error_log files which might be generated by the server. I propose to make a whitelist for all the classes. For example include only registered classes. Or at least filter if the file is a php file and more important check for a class in that php file so that the framework doesn’t crash.
    Thank you.

    #290

    Andy
    Keymaster

    Thanks for letting us know about these things. We’ll add them to the issues list. I didn’t realize it was pulling any file from the data-types but we’ll make sure it is specific to PHP in the next update.

    We’re hosting it at Github already, just in a private repository currently. I’m hoping to make that repository pubic very soon. If I can find the time to do that next week I will. It’s intended to be open source and under the same license as WordPress so I need to do a better job of facilitating access to it with a public repository. We’re crazy busy on this and other related projects so hang in there and we’ll get it released in a much more manageable format as soon as possible.

    Yes, you can use it for commercial projects. Once the documentation site goes live a lot of these things will be covered in the FAQs and other pages. Thanks for asking and for the awesome feedback! Let us know if you find anything else not working or suggestions for improvement.

    #292

    Zenger
    Member

    Thank you.
    I would be glad to help you in my free time to make a few additions or improvements.
    I’ll be waiting for a public git hub release.
    And it would be great if you could notify me on that afterwards.
    Cheerz.

    #293

    Andy
    Keymaster

    Just a quick update. I think I will be setting up the public Github repository this week. If not it will be next week. I’m going to be doing a LOT of Runway work in the next month so look for big changes, big announcements and hopefully even some new products and services based around Runway if things go well.

    #343

    Andy
    Keymaster

    FYI – The public repository went live about a week ago. I’m just getting around to sharing the news after returning from the PressNomics conference.

    https://github.com/parallelus/Runway_Framework

Viewing 6 posts - 1 through 6 (of 6 total)

You must be logged in to reply to this topic.